Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): customize envoy log level #4438

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Expose Envoy log level. I did not want to introduce meaningless log levels to kuma-dp itself, so it's a separate flag.
On Kubernetes, you can customize it with annotation kuma.io/envoy-log-level.
If you want to customize it on all envoys, you can either use KUMA_RUNTIME_KUBERNETES_INJECTOR_SIDECAR_CONTAINER_ENV_VARS or ContainerPatch.

Issues resolved

Fix #1820

Documentation

  • In progress

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

- [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
- [ ] Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner June 7, 2022 12:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #4438 (c3e98a2) into master (fdb3751) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4438      +/-   ##
==========================================
- Coverage   55.51%   55.48%   -0.03%     
==========================================
  Files         941      941              
  Lines       57669    57675       +6     
==========================================
- Hits        32014    32003      -11     
- Misses      23113    23116       +3     
- Partials     2542     2556      +14     
Impacted Files Coverage Δ
pkg/config/app/kuma-dp/config.go 63.47% <ø> (ø)
pkg/plugins/runtime/k8s/metadata/annotations.go 100.00% <ø> (ø)
app/kuma-dp/cmd/run.go 67.98% <100.00%> (+0.31%) ⬆️
app/kuma-dp/pkg/dataplane/envoy/envoy.go 79.34% <100.00%> (ø)
pkg/plugins/runtime/k8s/containers/factory.go 93.84% <100.00%> (+0.12%) ⬆️
pkg/plugins/common/postgres/connection.go 50.00% <0.00%> (-16.67%) ⬇️
pkg/clusterid/creator.go 73.33% <0.00%> (-13.34%) ⬇️
pkg/metrics/store/counter.go 74.54% <0.00%> (-10.91%) ⬇️
pkg/core/runtime/component/component.go 83.87% <0.00%> (-9.68%) ⬇️
pkg/plugins/resources/postgres/migrate.go 55.55% <0.00%> (-6.35%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb3751...c3e98a2. Read the comment docs.

Copy link
Contributor

@parkanzky parkanzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubdyszkiewicz jakubdyszkiewicz merged commit 42db672 into master Jun 8, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/envoy-log-level branch June 8, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warn log-level to kuma-dp
4 participants