New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): support for projected service account token #4453
Conversation
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4453 +/- ##
==========================================
+ Coverage 55.51% 55.56% +0.04%
==========================================
Files 941 941
Lines 57675 57719 +44
==========================================
+ Hits 32021 32072 +51
+ Misses 23111 23105 -6
+ Partials 2543 2542 -1
Continue to review full report at Codecov.
|
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For E2E test. Can we try on Universal with Dataplane token? You can save DP token to a file and have low expiration time
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Summary
When a token is renewed now Envoy is able to read and in case of disconnect with control plane is going to use a new one.
I have an issue with E2E test because to test I need to renew the token but the lowest expiration time can be set to 10 min, and I couldn't find a way how to renew it manually. If you have an idea of how to write the E2E test, I will add one.
Full changelog
Issues resolved
Fix #4121
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy