Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): support for projected service account token #4453

Merged
merged 6 commits into from Jun 27, 2022
Merged

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jun 9, 2022

Summary

When a token is renewed now Envoy is able to read and in case of disconnect with control plane is going to use a new one.

I have an issue with E2E test because to test I need to renew the token but the lowest expiration time can be set to 10 min, and I couldn't find a way how to renew it manually. If you have an idea of how to write the E2E test, I will add one.

Full changelog

  • [Support envoyGrpc and googleGrpc with reading from file]
  • [Added unit tests]

Issues resolved

Fix #4121

Documentation

Testing

  • Unit tests
  • E2E tests
  • [] Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner June 9, 2022 20:24
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #4453 (7ab78fd) into master (5124101) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4453      +/-   ##
==========================================
+ Coverage   55.51%   55.56%   +0.04%     
==========================================
  Files         941      941              
  Lines       57675    57719      +44     
==========================================
+ Hits        32021    32072      +51     
+ Misses      23111    23105       -6     
+ Partials     2543     2542       -1     
Impacted Files Coverage Δ
...pp/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go 63.15% <100.00%> (+2.98%) ⬆️
pkg/config/dp-server/config.go 42.55% <100.00%> (+1.24%) ⬆️
pkg/xds/bootstrap/components.go 88.23% <100.00%> (+0.73%) ⬆️
pkg/xds/bootstrap/generator.go 60.33% <100.00%> (+0.33%) ⬆️
pkg/xds/bootstrap/template_v3.go 99.31% <100.00%> (+0.10%) ⬆️
pkg/clusterid/creator.go 73.33% <0.00%> (-13.34%) ⬇️
pkg/plugins/common/postgres/listener.go 53.84% <0.00%> (-7.70%) ⬇️
pkg/kds/reconcile/reconciler.go 79.48% <0.00%> (-5.13%) ⬇️
pkg/core/runtime/component/component.go 90.32% <0.00%> (-3.23%) ⬇️
pkg/mads/server/server.go 80.90% <0.00%> (-2.73%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5124101...7ab78fd. Read the comment docs.

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For E2E test. Can we try on Universal with Dataplane token? You can save DP token to a file and have low expiration time

pkg/config/dp-server/config.go Outdated Show resolved Hide resolved
pkg/xds/bootstrap/template_v3.go Outdated Show resolved Hide resolved
pkg/xds/bootstrap/template_v3.go Outdated Show resolved Hide resolved
pkg/xds/bootstrap/template_v3.go Outdated Show resolved Hide resolved
@lukidzi lukidzi merged commit 28704c7 into master Jun 27, 2022
@lukidzi lukidzi deleted the feat/psat branch June 27, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support projected service account tokens
3 participants