Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): remove redirect-dns-upstream-target-chain from test #4573

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jul 8, 2022

Summary

Removed redirect-dns-upstream-target-chain from tests because it seems not be required anymore

Full changelog

  • [remove usage from tests]

Issues resolved

Fix kumahq/kuma-net#45

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

…uired for tests

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #4573 (f47995d) into master (ef44050) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4573      +/-   ##
==========================================
+ Coverage   47.05%   47.06%   +0.01%     
==========================================
  Files         677      677              
  Lines       45176    45178       +2     
==========================================
+ Hits        21259    21265       +6     
+ Misses      22049    22045       -4     
  Partials     1868     1868              
Impacted Files Coverage Δ
...p/kumactl/cmd/install/install_transparent_proxy.go 74.31% <100.00%> (+0.28%) ⬆️
pkg/plugins/leader/postgres/leader_elector.go 82.97% <0.00%> (-6.39%) ⬇️
pkg/xds/cache/once/once.go 100.00% <0.00%> (+5.00%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (+5.12%) ⬆️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+5.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef44050...f47995d. Read the comment docs.

@lukidzi lukidzi marked this pull request as ready for review July 11, 2022 07:40
@lukidzi lukidzi requested a review from a team as a code owner July 11, 2022 07:40
@lukidzi lukidzi changed the title chore(*): deprecate redirect-dns-upstream-target-chain is not more required chore(*): remove redirect-dns-upstream-target-chain from test Jul 11, 2022
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi merged commit 01f8dc4 into kumahq:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate whether we need --redirect-dns-upstream-target-chain
3 participants