Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): use image.global.registry for imageExperimental #4641

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Instead of hardcoding registry, we leave it empty so we can infer this from image.global.registry

Issues resolved

No issues reported.

Documentation

- [ ] Link to the website documentation PR

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

- [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
- [ ] Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner July 19, 2022 11:43
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4641 (0740d39) into master (589eb10) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4641   +/-   ##
=======================================
  Coverage   46.57%   46.57%           
=======================================
  Files         684      684           
  Lines       46323    46323           
=======================================
+ Hits        21576    21577    +1     
+ Misses      22834    22833    -1     
  Partials     1913     1913           
Impacted Files Coverage Δ
pkg/xds/cache/once/cache.go 87.17% <0.00%> (-7.70%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.90% <0.00%> (+1.13%) ⬆️
pkg/plugins/leader/postgres/leader_elector.go 89.36% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589eb10...0740d39. Read the comment docs.

@slonka slonka merged commit 881d534 into kumahq:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants