Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(.github): put PR template instructions in comments #4680

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jul 26, 2022

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 26, 2022 18:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #4680 (d031943) into master (93056a7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4680   +/-   ##
=======================================
  Coverage   46.47%   46.48%           
=======================================
  Files         684      684           
  Lines       46500    46500           
=======================================
+ Hits        21613    21617    +4     
+ Misses      22976    22973    -3     
+ Partials     1911     1910    -1     
Impacted Files Coverage Δ
pkg/xds/generator/direct_access_proxy_generator.go 90.90% <0.00%> (+1.13%) ⬆️
pkg/xds/cache/once/once.go 100.00% <0.00%> (+5.00%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93056a7...d031943. Read the comment docs.

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 26, 2022 18:22
@michaelbeaumont michaelbeaumont merged commit a4f8c17 into kumahq:master Jul 26, 2022
@michaelbeaumont michaelbeaumont deleted the chore/pr_template_comments branch July 26, 2022 19:58
@lahabana lahabana changed the title chore(.github): put PR template instructions in comments docs(.github): put PR template instructions in comments Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants