Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuma-cp: add HealthCheck to core model #470

Merged
merged 2 commits into from
Dec 9, 2019
Merged

kuma-cp: add HealthCheck to core model #470

merged 2 commits into from
Dec 9, 2019

Conversation

yskopets
Copy link
Contributor

@yskopets yskopets commented Dec 4, 2019

Summary

  • add HealthCheck to core model

@yskopets yskopets requested review from a team and jakubdyszkiewicz December 4, 2019 15:21
@yskopets yskopets added this to the 0.4.0 milestone Dec 4, 2019
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about kumactl part :)

pkg/core/resources/apis/mesh/health_check.go Outdated Show resolved Hide resolved
@yskopets yskopets changed the base branch from feature/add-health-check-proto to master December 9, 2019 08:22
@yskopets yskopets changed the base branch from master to feature/add-health-check-proto December 9, 2019 08:23
@yskopets yskopets force-pushed the feature/add-health-check-resource branch from 4eb39b5 to 669674c Compare December 9, 2019 08:29
@yskopets yskopets changed the base branch from feature/add-health-check-proto to master December 9, 2019 08:30
@yskopets yskopets merged commit 92ac06e into master Dec 9, 2019
@yskopets yskopets deleted the feature/add-health-check-resource branch December 19, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yskopets @jakubdyszkiewicz