Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PR template #4787

Merged
merged 2 commits into from
Aug 10, 2022
Merged

chore: update PR template #4787

merged 2 commits into from
Aug 10, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Aug 9, 2022

Update PR template to include warning about things that might break projects that depend on kuma

Signed-off-by: Krzysztof Słonka slonka@users.noreply.github.com

Checklist prior to review

  • Link to docs PR or issue -- PR tempalte change, same for everything below
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

Update PR template to include warning about hardcoding values that might break projects that depend on kuma

Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
@slonka slonka requested a review from a team as a code owner August 9, 2022 09:31
add line about windows / linux compatibility

Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4787 (6eeeec7) into master (4c18e48) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4787      +/-   ##
==========================================
+ Coverage   46.44%   46.46%   +0.01%     
==========================================
  Files         690      690              
  Lines       47086    47086              
==========================================
+ Hits        21870    21877       +7     
+ Misses      23290    23285       -5     
+ Partials     1926     1924       -2     
Impacted Files Coverage Δ
pkg/defaults/components.go 53.33% <0.00%> (-3.34%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.77% <0.00%> (-1.14%) ⬇️
pkg/api-server/server.go 77.68% <0.00%> (+2.89%) ⬆️
pkg/xds/cache/once/once.go 100.00% <0.00%> (+5.00%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (+5.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@slonka slonka merged commit ff4603a into master Aug 10, 2022
@slonka slonka deleted the chore/update-pr-template branch August 10, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants