Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuma-cp: pick a single the most specific HealthCheck for every service reachable from a given a Dataplane (via outbound interfaces and TrafficRoutes) #481

Merged
merged 1 commit into from
Dec 11, 2019
Merged

kuma-cp: pick a single the most specific HealthCheck for every service reachable from a given a Dataplane (via outbound interfaces and TrafficRoutes) #481

merged 1 commit into from
Dec 11, 2019

Conversation

yskopets
Copy link
Contributor

Summary

  • pick a single the most specific HealthCheck for every service reachable from a given a Dataplane (via outbound interfaces and TrafficRoutes)

@yskopets yskopets requested review from a team and jakubdyszkiewicz December 10, 2019 17:47
@yskopets yskopets added this to the 0.4.0 milestone Dec 10, 2019
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the second case where I'd agree that additive applying of resources makes more sense.

@yskopets yskopets force-pushed the refactoring/generalize-select-outbound-connection-policies branch from f1f9d95 to ba1935d Compare December 11, 2019 14:18
@yskopets yskopets force-pushed the feature/pick-the-most-specific-health-check-per-destination-service branch from f4b5e23 to a5611af Compare December 11, 2019 14:19
@yskopets yskopets force-pushed the refactoring/generalize-select-outbound-connection-policies branch 2 times, most recently from d76dde0 to 60fcc7d Compare December 11, 2019 15:02
@yskopets yskopets changed the base branch from refactoring/generalize-select-outbound-connection-policies to master December 11, 2019 15:25
@yskopets
kuma-cp: pick a single the most specific HealthCheck for every servic…
12726a6 
…e reachable from a given a Dataplane (via outbound interfaces and TrafficRoutes)
@yskopets yskopets force-pushed the feature/pick-the-most-specific-health-check-per-destination-service branch from a5611af to 12726a6 Compare December 11, 2019 15:32
@yskopets yskopets merged commit 22ff732 into master Dec 11, 2019
@yskopets yskopets deleted the feature/pick-the-most-specific-health-check-per-destination-service branch December 19, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yskopets @jakubdyszkiewicz