feat(kuma-cp) validate ca on k8s #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/provided-ca-validation-k8s
branch
from
4c91a54
to
e377c0f
Compare
yskopets
suggested changes
Dec 12, 2019
| @@ -210,3 +210,27 @@ webhooks: | |||
| - dataplanes | |||
| - meshes | |||
| - proxytemplates | |||
| --- | |||
| apiVersion: admissionregistration.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
Let's avoid a separate validating web hook for this.
It's an internal implementation detail that we use different components that contribute to overall validation.
We could use a "composite" handler to encapsulate this.
pkg/plugins/runtime/k8s/plugin.go
Outdated
| return err | ||
| } | ||
| func addValidators(mgr kube_ctrl.Manager, rt core_runtime.Runtime) error { | ||
| handler := k8s_webhooks.NewValidatingWebhook(k8s_resources.DefaultConverter(), core_registry.Global(), k8s_registry.Global()) |
There was a problem hiding this comment.
Let's wrap this handler into a "composite" handler (aggregate over a list of handlers).
"composite" handler goes over a list and calls Handle until the first denied response.
The list of handlers will consist of this one and the new Mesh-specific one.
jakubdyszkiewicz
force-pushed
the
feature/provided-ca-validation
branch
2 times, most recently
from
ff4822a
to
4d68095
Compare
jakubdyszkiewicz
force-pushed
the
feature/provided-ca-validation-k8s
branch
from
e377c0f
to
182f186
Compare
jakubdyszkiewicz
changed the base branch from
feature/provided-ca-validation
to
master
yskopets
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wire mesh validator on K8S