feat(kuma-cp) Gateway mode in Dataplane on K8S #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
What if we don't find any services associated with pod? Right now we create Dataplane anyways with empty inbound object which is not valid from the Kuma CP core perspective.
Validation web hook will reject such a Dataplane anyway. And, it least, this error will be visible through metrics.
We have a follow-up task to address a case of a Dataplane without inbound interfaces.
| @@ -50,6 +49,8 @@ func (i *KumaInjector) InjectKuma(pod *kube_core.Pod) error { | |||
| for key, value := range i.NewAnnotations(pod) { | |||
| pod.Annotations[key] = value | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
We do we need to split if pod.Spec.InitContainers == nil { and pod.Spec.InitContainers = .
Let's move both statements at the same time
jakubdyszkiewicz
force-pushed
the
feature/dataplane-gateway
branch
2 times, most recently
from
998c511
to
79f5e3f
Compare
jakubdyszkiewicz
force-pushed
the
feature/dataplane-gateway-kubernetes
branch
from
7449cae
to
d0c2d5d
Compare
jakubdyszkiewicz
changed the base branch from
feature/dataplane-gateway
to
master
|
Do we need another PR to enable this feature in Universal? |
|
@subnetmarco It's already there https://github.com/Kong/kuma/pull/503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support of Gateway on K8S.
Gateway in DP objects gets tags of the first inbound object.
Side question:
What if we don't find any services associated with pod? Right now we create Dataplane anyways with empty inbound object which is not valid from the Kuma CP core perspective.