Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuma-cp: make port of Envoy Admin API available to Envoy config generators #508

Merged
merged 2 commits into from
Dec 23, 2019
Merged

kuma-cp: make port of Envoy Admin API available to Envoy config generators #508

merged 2 commits into from
Dec 23, 2019

Conversation

yskopets
Copy link
Contributor

@yskopets yskopets commented Dec 20, 2019 •
edited

Summary

  • make port of Envoy Admin API available to Envoy config generators

@yskopets yskopets requested review from a team and jakubdyszkiewicz December 20, 2019 16:39
@yskopets yskopets added this to the 0.4.0 milestone Dec 20, 2019
jakubdyszkiewicz
jakubdyszkiewicz reviewed Dec 20, 2019
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we introduce new naming convention to metadata dataplane.admin.port maybe it's a good idea to change the old one dataplaneTokenPath? Especially now when breaking changes are not that painful?

@yskopets yskopets force-pushed the feature/envoy-admin-port-in-config-generators branch from 3c83d60 to a8df000 Compare December 20, 2019 17:35
@yskopets yskopets changed the title feature: make port of Envoy Admin API available to Envoy config generators kuma-cp: make port of Envoy Admin API available to Envoy config generators Dec 20, 2019
@yskopets
Copy link
Contributor Author

@jakubdyszkiewicz Yes, I would like to use dot notation for new metadata fields.

This PR introduces a new feature and doesn't require any backwards-incompatible changes.

In contrast, renaming an existing metadata field would be a backwards-incompatible change. I would prefer to do it in a separate PR.

@yskopets yskopets merged commit 37cb680 into master Dec 23, 2019
@devadvocado devadvocado deleted the feature/envoy-admin-port-in-config-generators branch March 30, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yskopets @jakubdyszkiewicz