Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): inspect rule based view #5189

Merged
merged 4 commits into from Oct 24, 2022
Merged

feat(kuma-cp): inspect rule based view #5189

merged 4 commits into from Oct 24, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Oct 21, 2022 •
edited by lukidzi

Signed-off-by: Jakub Dyszkiewicz jakub.dyszkiewicz@gmail.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR -- no issue
  • Is the issue worked on linked? -- inspect api for rule based view policies #5036
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? -- no
  • Does it need to be backported according to the backporting policy? -- no
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(inspect): implement rule-based view for new policies

@jakubdyszkiewicz
feat(kuma-cp): inspect rule based view
39118e9 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
chore: sort attachments
3d3f12f 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review October 21, 2022 12:42
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 21, 2022 12:43
@lahabana lahabana removed the request for review from a team October 21, 2022 13:18
@jakubdyszkiewicz jakubdyszkiewicz mentioned this pull request Oct 24, 2022
Merged
12 tasks
lahabana
lahabana reviewed Oct 24, 2022
View reviewed changes
pkg/api-server/inspect_endpoints.go Show resolved Hide resolved
pkg/api-server/inspect_endpoints_test.go Outdated Show resolved Hide resolved
pkg/api-server/inspect_endpoints.go Outdated Show resolved Hide resolved
pkg/api-server/inspect_endpoints.go Outdated Show resolved Hide resolved
pkg/core/xds/matched_rules.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz
chore: review
d70e102 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
chore: move to xds inspect
6f6dd35 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 5107654 into kumahq:master Oct 24, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/inspect-rules branch October 24, 2022 11:21
This was referenced Oct 24, 2022
Merged
Closed
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@lobkovilya lobkovilya lobkovilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubdyszkiewicz @lahabana @lobkovilya