feat(kuma-cp) redirect requests from gui server to api server #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
approved these changes
Jan 3, 2020
app/kuma-ui/pkg/server/server.go
Outdated
| srv := Server{rt.Config().GuiServer} | ||
| srv := Server{ | ||
| Config: rt.Config().GuiServer, | ||
| ApiServerPort: rt.Config().ApiServer.Port, |
There was a problem hiding this comment.
Why ApiServerPort is not a part of Config ?
There was a problem hiding this comment.
Moved as a part of the configuration.
app/kuma-ui/pkg/server/server.go
Outdated
| @@ -64,6 +76,21 @@ func (g *Server) Start(stop <-chan struct{}) error { | |||
| } | |||
| } | |||
|
|
|||
| func (g *Server) apiHandler() (http.Handler, error) { | |||
| apiServerUrl, err := url.Parse(fmt.Sprintf("http://localhost:%d", g.ApiServerPort)) | |||
There was a problem hiding this comment.
Why do we need to hardcode it here instead of making it a part of configuration ?
There was a problem hiding this comment.
Moved as a part of the configuration.
app/kuma-ui/pkg/server/server.go
Outdated
| if err := core_runtime.Add(rt, &srv); err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| type Server struct { | ||
| Config *gui_server.GuiServerConfig | ||
| Config *gui_server.GuiServerConfig |
There was a problem hiding this comment.
Should we deprecate the old ApiUrl field ?
There was a problem hiding this comment.
Added deprecation.
jakubdyszkiewicz
force-pushed
the
feature/redirect-gui-to-api
branch
from
174f7fb
to
321fba4
Compare
|
@yskopets @jakubdyszkiewicz what does this mean for the way I'm fetching the API and config? Is there anything I need to change or will it still work as is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Redirect requests from GUI on /api prefix to API Server. This simplifies setup since you don't have to coordinate exposing GUI and API server and configuring proper external address.