feat(kuma-cp) Added creation and modification time to core entities #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/creation-date
branch
from
8020aa0
to
39c7557
Compare
yskopets
reviewed
Jan 29, 2020
| statement := `INSERT INTO resources VALUES ($1, $2, $3, $4, $5, $6);` | ||
| _, err = r.db.Exec(statement, opts.Name, "", opts.Mesh, resource.GetType(), version, string(bytes)) // todo(jakubdyszkiewicz) solve db migration | ||
| statement := `INSERT INTO resources VALUES ($1, $2, $3, $4, $5, $6, $7, $8);` | ||
| now := time.Now() |
There was a problem hiding this comment.
Why creationTime/modificationTime is set at DAO layer instead of Service layer ?
| @@ -107,11 +111,13 @@ func (r *postgresResourceStore) Update(_ context.Context, resource model.Resourc | |||
| if err != nil { | |||
| return errors.Wrap(err, "failed to convert meta version to int") | |||
| } | |||
| statement := `UPDATE resources SET spec=$1, version=$2 WHERE name=$3 AND mesh=$4 AND type=$5 AND version=$6;` | |||
| statement := `UPDATE resources SET spec=$1, version=$2, modification_time=$3 WHERE name=$4 AND mesh=$5 AND type=$6 AND version=$7;` | |||
| now := time.Now() | |||
There was a problem hiding this comment.
Why modificationTime is set at DAO layer instead of Service layer ?
| @@ -74,10 +85,13 @@ func (c *memoryStore) Create(_ context.Context, r model.Resource, fs ...store.Cr | |||
| return store.ErrorResourceAlreadyExists(r.GetType(), opts.Name, opts.Mesh) | |||
| } | |||
|
|
|||
| now := time.Now() | |||
There was a problem hiding this comment.
Why creationTime/modificationTime is set at DAO layer instead of Service layer ?
| @@ -114,6 +128,7 @@ func (c *memoryStore) Update(_ context.Context, r model.Resource, fs ...store.Up | |||
| return store.ErrorResourceConflict(r.GetType(), r.GetMeta().GetName(), r.GetMeta().GetMesh()) | |||
| } | |||
| meta.Version = meta.Version.Next() | |||
| meta.ModificationTime = time.Now() | |||
There was a problem hiding this comment.
Why modificationTime is set at DAO layer instead of Service layer ?
jakubdyszkiewicz
force-pushed
the
feature/creation-date
branch
from
c3e3c85
to
67e23e6
Compare
yskopets
approved these changes
Feb 4, 2020
jakubdyszkiewicz
force-pushed
the
feature/creation-date
branch
from
67e23e6
to
e277f8b
Compare
tharun208
pushed a commit
to tharun208/kuma
that referenced
this pull request
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added creation and modification time to core entities including postgres migration.
It's not yet exposed on kumactl/API server. If we want to expose it on API side, lets discuss it and do it as a separate PR.
On K8S there is no distinction between creation and modification date therefore we always use creation time.