feat(kuma-cp) order matching policies by modification time #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
approved these changes
Jan 3, 2020
jakubdyszkiewicz
force-pushed
the
feature/creation-date
branch
from
8020aa0
to
39c7557
Compare
jakubdyszkiewicz
force-pushed
the
feature/creation-date
branch
from
67e23e6
to
e277f8b
Compare
jakubdyszkiewicz
force-pushed
the
feature/creation-date-matching
branch
from
a5bfa75
to
dd18dcd
Compare
jakubdyszkiewicz
changed the base branch from
feature/creation-date
to
master
tharun208
pushed a commit
to tharun208/kuma
that referenced
this pull request
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added ordering matching policies by modification time.
I think we should only resolve conflicts on final choice, otherwise we can eliminate valid policy.