kuma-dp: enable Envoy Admin API by default with an option to opt out #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
feature/enable-kuma-dp-admin-port-by-default
branch
from
a8cc6f7
to
68db76d
Compare
jakubdyszkiewicz
approved these changes
Jan 7, 2020
| lowestPort, highestPort = highestPort, lowestPort | ||
| } | ||
| // we prefer a port to remain stable over time, that's why we do sequential availability check | ||
| // instead of random selection |
There was a problem hiding this comment.
What is the use case to have it stable?
There was a problem hiding this comment.
It's probably opinionated.
When, as a user, I define a port range 9901-9999, I expect that application will choose the first available port.
yskopets
force-pushed
the
feature/enable-kuma-dp-admin-port-by-default
branch
from
68db76d
to
6b57b8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kuma-dpEnvoy Admin APIby default with an option to opt out--admin-portoption now accepts a port or range of ports to choose from, e.g.99019901-99999901--9901--admin-porthas changed from `` (empty) to30001-65535kuma-dpwill pick the first available port from the range