Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nil dereference in MeshAccessLog configurer #5258

Merged
merged 1 commit into from Nov 3, 2022
Merged

fix: nil dereference in MeshAccessLog configurer #5258

merged 1 commit into from Nov 3, 2022

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Nov 3, 2022 •
edited by lukidzi

Accessing Format.Json without checking if Format is not nil. This PR replaces the pointer to Format with value.

Signed-off-by: Ilya Lobkov ilya.lobkov@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: fix(api): nil dereference in MeshAccessLog configurer

@lobkovilya
fix: replace pointer to Format with value
8116610 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner November 3, 2022 13:46
@lobkovilya lobkovilya changed the title fix: NPE in MeshAccessLog configurer fix: nil dereference in MeshAccessLog configurer Nov 3, 2022
@lobkovilya lobkovilya merged commit c196b78 into kumahq:release-2.0 Nov 3, 2022
@lobkovilya lobkovilya deleted the fix/npe-mal branch November 3, 2022 15:18
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lobkovilya @lukidzi