Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring: make Resource types reusable by both primary ADS server and future MADS server #526

Merged
merged 3 commits into from
Jan 10, 2020
Merged

refactoring: make Resource types reusable by both primary ADS server and future MADS server #526

merged 3 commits into from
Jan 10, 2020

Conversation

yskopets
Copy link
Contributor

@yskopets yskopets commented Jan 8, 2020

Summary

  • make Resource type reusable
  • make ResourceList type reusable
  • make ResourceSet type reusable

@yskopets yskopets requested review from a team and jakubdyszkiewicz January 8, 2020 11:18
@yskopets yskopets added this to the 0.4.0 milestone Jan 8, 2020
@yskopets yskopets force-pushed the feature/prometheus-xds-proto branch from a81e2fa to 99d87b0 Compare January 8, 2020 11:38
@yskopets yskopets force-pushed the refactoring/make-resource-type-reusable branch from 59e4bb5 to 794158f Compare January 8, 2020 11:39
@yskopets yskopets changed the base branch from feature/prometheus-xds-proto to master January 10, 2020 08:10
@yskopets yskopets force-pushed the refactoring/make-resource-type-reusable branch from 794158f to 5baffbf Compare January 10, 2020 08:12
@yskopets yskopets merged commit 0f30db2 into master Jan 10, 2020
@devadvocado devadvocado deleted the refactoring/make-resource-type-reusable branch March 30, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yskopets @jakubdyszkiewicz