Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring: refactor out dataplane.GetPrometheusEndpoint(mesh) method #533

Merged
merged 1 commit into from
Jan 10, 2020
Merged

refactoring: refactor out dataplane.GetPrometheusEndpoint(mesh) method #533

merged 1 commit into from
Jan 10, 2020

Conversation

yskopets
Copy link
Contributor

@yskopets yskopets commented Jan 9, 2020

Summary

  • refactor out dataplane.GetPrometheusEndpoint(mesh) method

@yskopets yskopets requested review from a team and jakubdyszkiewicz January 9, 2020 10:08
@yskopets yskopets added this to the 0.4.0 milestone Jan 9, 2020
@yskopets yskopets force-pushed the refactoring/get-prometheus-endpoint branch from 2a7c6b3 to e36dc44 Compare January 9, 2020 10:36
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't I see this already in some other PR?

@yskopets yskopets force-pushed the refactoring/get-prometheus-endpoint branch from e36dc44 to 6812f5e Compare January 10, 2020 12:13
@yskopets yskopets changed the base branch from feature/mads-server to master January 10, 2020 16:38
@yskopets yskopets force-pushed the refactoring/get-prometheus-endpoint branch from 6812f5e to 5ca8d69 Compare January 10, 2020 16:39
@yskopets yskopets merged commit 32c339e into master Jan 10, 2020
@devadvocado devadvocado deleted the refactoring/get-prometheus-endpoint branch March 30, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yskopets @jakubdyszkiewicz