Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuma-prometheus-sd: implement xDS client and integrate with Prometheus via file_sd discovery #537

Merged
merged 3 commits into from
Jan 10, 2020
Merged

kuma-prometheus-sd: implement xDS client and integrate with Prometheus via file_sd discovery #537

merged 3 commits into from
Jan 10, 2020

Conversation

yskopets
Copy link
Contributor

@yskopets yskopets commented Jan 9, 2020

Summary

  • implement xDS client and integrate with Prometheus via file_sd discovery

@yskopets yskopets requested review from a team and jakubdyszkiewicz January 9, 2020 22:08
@yskopets yskopets added this to the 0.4.0 milestone Jan 9, 2020
@yskopets yskopets force-pushed the feature/kuma-prometheus-sd-implement-xds-client branch from 36cdeb7 to c306473 Compare January 9, 2020 22:14
@yskopets yskopets force-pushed the feature/kuma-prometheus-sd-implement-xds-client branch from c306473 to b5b0065 Compare January 9, 2020 22:38
jakubdyszkiewicz
jakubdyszkiewicz reviewed Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are tests coming in a separate PR?

app/kuma-prometheus-sd/pkg/discovery/xds/xds.go Outdated
}

log.Info("closing an xDS stream ...")
if err := stream.Close(); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that Close() was already called in defer. Why call it two times?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworked

@yskopets yskopets force-pushed the feature/kuma-prometheus-sd-implement-xds-client branch from 43e9e6f to 1c2aa5a Compare January 10, 2020 13:13
@yskopets yskopets force-pushed the feature/kuma-prometheus-sd-implement-xds-client branch from 1c2aa5a to 648a255 Compare January 10, 2020 13:53
@yskopets yskopets force-pushed the feature/kuma-prometheus-sd-implement-xds-client branch from 648a255 to a678c9b Compare January 10, 2020 16:46
@yskopets yskopets force-pushed the feature/kuma-prometheus-sd-implement-xds-client branch from a678c9b to bfbf0f3 Compare January 10, 2020 17:08
@yskopets yskopets force-pushed the feature/kuma-prometheus-sd-implement-xds-client branch from bfbf0f3 to fc7a341 Compare January 10, 2020 18:58
@yskopets yskopets changed the base branch from feature/prom-sd-add-config to master January 10, 2020 22:13
@yskopets yskopets merged commit d3ae794 into master Jan 10, 2020
@devadvocado devadvocado deleted the feature/kuma-prometheus-sd-implement-xds-client branch March 30, 2020 13:16
@jpeach jpeach mentioned this pull request Jul 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yskopets @jakubdyszkiewicz