Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): fix prune in docker sh - "--all" #5404

Merged
merged 1 commit into from Dec 2, 2022
Merged

feat(build): fix prune in docker sh - "--all" #5404

merged 1 commit into from Dec 2, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Dec 2, 2022 •
edited by lahabana

Signed-off-by: slonka slonka@users.noreply.github.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(build): idempotent build

@slonka
feat(build): fix prune in docker sh
5a0e67a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka requested a review from a team as a code owner December 2, 2022 08:13
@slonka slonka merged commit 75a85ec into kumahq:master Dec 2, 2022
@slonka slonka deleted the fix-prune-in-docker-sh-2 branch December 2, 2022 08:15
@slonka slonka changed the title feat(build): fix prune in docker sh feat(build): fix prune in docker sh - "--all" Dec 2, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slonka @bartsmykla