Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): fixed error when logging ExternalServiceResourceList and MeshResourceList #5423

Merged
merged 9 commits into from Dec 19, 2022
Merged

fix(kuma-cp): fixed error when logging ExternalServiceResourceList and MeshResourceList #5423

merged 9 commits into from Dec 19, 2022

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Dec 5, 2022

Signed-off-by: Marcin Skalski marcin.skalski@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@Automaat
feat(kuma-cp): fixed error when logging ExternalServiceResourceList a…
aaa107b 
…nd MeshResourceList

Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested a review from a team as a code owner December 5, 2022 14:28
@lobkovilya
Copy link
Contributor

Is it possible to add a unit test that reproduces the issue?

@michaelbeaumont michaelbeaumont changed the title feat(kuma-cp): fixed error when logging ExternalServiceResourceList and MeshResourceList fix(kuma-cp): fixed error when logging ExternalServiceResourceList and MeshResourceList Dec 5, 2022
@Automaat
Copy link
Contributor Author

Automaat commented Dec 5, 2022

Is it possible to add a unit test that reproduces the issue?
@lobkovilya yes, since any invocation of MarshallLog on method ExternalServiceResourceList and MeshResourceList will cause this error, I can add unit test for it

@Automaat
fix(kuma-cp): add unit tests
a0f2fbc 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
fix(kuma-cp): more concrete tests^
1844625 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into fix/secret_logging
f3ec00c
@Automaat
feat(kuma-cp): fixed check
8ad9916 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
feat(kuma-cp): fix test naming
7663a1f 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested review from a team, jakubdyszkiewicz and bartsmykla and removed request for a team December 13, 2022 11:21
@Automaat Automaat merged commit db63897 into kumahq:master Dec 19, 2022
@Automaat Automaat deleted the fix/secret_logging branch December 19, 2022 13:06
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya left review comments

@lahabana lahabana lahabana approved these changes

@lukidzi lukidzi lukidzi approved these changes

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Automaat @lobkovilya @lahabana @lukidzi