Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inspect): remove spec from inspect policy output #5491

Merged
merged 1 commit into from Dec 13, 2022
Merged

fix(inspect): remove spec from inspect policy output #5491

merged 1 commit into from Dec 13, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Dec 13, 2022 •
edited

It's redundant and makes the response very big.
It was also not very straight forward with new and old policy

While this is a breaking change, we strictly remove things which shouldn't be an issue (kumactl was already not showing this)

Fix #5383

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • Link to docs PR or issue -- fix: improve http doc for inspect policy api kuma-website#1171
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: fix(api-server): remove spec from inspect policy output

@lahabana lahabana requested review from a team, slonka and jakubdyszkiewicz and removed request for a team December 13, 2022 13:08
@lahabana lahabana linked an issue Dec 13, 2022 that may be closed by this pull request
kumactl inspect dataplane --type policies panic #5383
Closed
@lahabana lahabana enabled auto-merge (squash) December 13, 2022 13:19
lobkovilya
lobkovilya approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahabana
fix(inspect): remove spec from inspect policy output
c860556 
It's redudundant and makes the response very big.
It was also not very straight forward with new and old policy

While this is a breaking change, we strictly remove things which
shouldn't be an issue (kumactl was already not showing this)

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana merged commit 1da51bd into kumahq:master Dec 13, 2022
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
@lahabana lahabana deleted the fix5383 branch May 2, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

@slonka slonka Awaiting requested review from slonka

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kumactl inspect dataplane --type policies panic
2 participants
@lahabana @lobkovilya