docs: add proposal how users should indicate application protocol of a service #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f a service [ci skip]
yskopets
force-pushed
the
docs/proposal-l7-protocols
branch
from
5433653
to
ad05cb8
Compare
|
|
||
| ## Open questions | ||
|
|
||
| 1. What happens if a user defines different `protocol` tag for the same `service` in different `Dataplanes` ? |
There was a problem hiding this comment.
We need this information when generating inbound listeners, right? We generate listener for a given dataplane, so if one DP is defined with TCP then TCP listener will be generated, if DP is defined with HTTP then HTTP listener will be generated.
| - api: | ||
| rest: | ||
| spec: | ||
| url: https://generator.swagger.io/api/swagger.json |
There was a problem hiding this comment.
What can we do with such information?
LinkerD has this to generate endpoints for which then metrics are collected, but we don't need it once generate listener with http connection manager filter.
| - port: 7070 | ||
| name: http-metrics # `http` protocol in the `name` | ||
| - port: 6060 | ||
| name: somethinggrpc # `grpc` protocol in the `name` |
There was a problem hiding this comment.
What if I have both in the name? Example: grpc-http-bridge
subnetmarco
reviewed
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary