Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow injecting env from parent projects #5677

Merged
merged 1 commit into from Jan 12, 2023
Merged

feat: allow injecting env from parent projects #5677

merged 1 commit into from Jan 12, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Jan 12, 2023 •
edited by lahabana

Signed-off-by: slonka slonka@users.noreply.github.com

Needed by the enterprise project.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(helm): allow injecting env from parent projects

@slonka
feat: allow injecting env from parent projects
ebbf16b 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka added the ci/skip-e2e-test PR: Don't run e2e tests label Jan 12, 2023
@slonka slonka requested review from a team, jakubdyszkiewicz and bartsmykla and removed request for a team January 12, 2023 15:06
@slonka slonka merged commit 7fd7e59 into kumahq:master Jan 12, 2023
@slonka slonka deleted the feat-allow-injecting-env-from-parent-project branch January 12, 2023 15:38
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@slonka @bartsmykla
feat: allow injecting env from parent projects (kumahq#5677)
2431626 
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@slonka @bartsmykla
feat: allow injecting env from parent projects (kumahq#5677)
96fc643 
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

Assignees
No one assigned
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slonka @jakubdyszkiewicz