Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and get rid of magic number #569

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Fix typo and get rid of magic number #569

merged 1 commit into from
Feb 7, 2020

Conversation

programmer04
Copy link
Contributor

Fix typo in error message, change 200 to predefined constant for OK status code and sort imports.

@programmer04 programmer04 requested a review from a team February 6, 2020 20:42
@claassistantio
Copy link

claassistantio commented Feb 6, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 5fd7015 into kumahq:master Feb 7, 2020
@jakubdyszkiewicz
Copy link
Contributor

Thanks!

@programmer04 programmer04 deleted the fix-err-msg branch February 7, 2020 09:52
tharun208 pushed a commit to tharun208/kuma that referenced this pull request Feb 7, 2020
@programmer04 @tharun208
fix(kumactl) typo and get rid of magic number (kumahq#569)
0e38f68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@programmer04 @claassistantio @jakubdyszkiewicz