refactoring: refactor Envoy config generators to be modular and composable #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
refactoring/envoy-config-generators
branch
from
380083e
to
b26055e
Compare
golangcibot
reviewed
Feb 7, 2020
yskopets
force-pushed
the
refactoring/envoy-config-generators
branch
from
b26055e
to
11d0d55
Compare
golangcibot
reviewed
Feb 7, 2020
yskopets
force-pushed
the
refactoring/envoy-config-generators
branch
from
11d0d55
to
b6c7868
Compare
There was a problem hiding this comment.
Nice work, I like it 👍
A couple of suggestions:
- Move all stuff connected with listeners to
pkg/xds/envoy/listenersorpkg/xds/envoy/lds - Move all stuff connected with clusters to
pkg/xds/envoy/clusters. Just move without refactor to similar pattern. We can do it later if needed - Move all stuff connected with endpoints to
pkg/xds/envoy/endpoints. Just move without refactor to similar pattern. - Move all TLS stuff to
pkg/xds/envoy/tls.go
This way we get rid of this envoy.go file so it won't become this "envoy generation god file" that it was before.
What do you think?
pkg/xds/envoy/builder.go
Outdated
|
|
||
| // ListenerBuilder is responsible for generating an Envoy listener | ||
| // by applying a series of ListenerConfigurers. | ||
| type ListenerBuilder interface { |
There was a problem hiding this comment.
Should this be really an interface? I think struct is enough
Done |
jakubdyszkiewicz
approved these changes
Feb 10, 2020
jakubdyszkiewicz
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary