kuma-cp: generate HTTP-specific inbound listeners for services tagged with protocol: http
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
approved these changes
Feb 11, 2020
| @@ -84,3 +105,14 @@ func (d *DataplaneResource) GetIP() string { | |||
| } | |||
| return ifaces[0].DataplaneIP | |||
| } | |||
|
|
|||
| func (d *DataplaneResource) GetProtocol(idx int) Protocol { | |||
There was a problem hiding this comment.
How about idx -> inboundIdx? I had to read the func body to know what is it about.
| } | ||
|
|
||
| pbst, err := ptypes.MarshalAny(config) | ||
| util_error.MustNot(err) |
There was a problem hiding this comment.
Isn't it better to rethrow this error just in case? Or are we 100% sure this won't be an error?
There was a problem hiding this comment.
MustNot(err) has been replaced with propagation
… with `protocol: http`
yskopets
force-pushed
the
feature/generate-inbound-listeners-for-http-traffic
branch
from
0a93f21
to
7480f09
Compare
yskopets
changed the base branch from
refactoring/refactor-out-reusable-func
to
master
jakubdyszkiewicz
approved these changes
Feb 12, 2020
devadvocado
deleted the
feature/generate-inbound-listeners-for-http-traffic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol: http