Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): automatically apply security updates for release branches #5758

Merged

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Jan 19, 2023

Example PRs:

Example output:

Once the PR is merged a new one won't be created. Also running action multiple times just updates the PR if there are things to update.

Signed-off-by: slonka slonka@users.noreply.github.com

Checklist prior to review

  • Link to docs PR or issue -- will issue link if the PR get's accepted
  • Link to UI issue or PR -- not a UI issue
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests -- only manual tests
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? -- no, actions are taken from main branch
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(security): add dependabot security updates to release branches

… release branches

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Jan 19, 2023
@slonka slonka requested review from a team, Automaat and lukidzi and removed request for a team January 19, 2023 09:09
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great initiative!

Was this considered as an option: https://github.com/G-Rath/check-with-osv-detector ?

@slonka
Copy link
Contributor Author

slonka commented Jan 19, 2023

Was this considered as an option: https://github.com/G-Rath/check-with-osv-detector ?

I think it's just a different CLI and I'm just using the official one. From what I saw the action does not do anything interesting just spits out the scan result, we'd still have to parse it and attempt dependency update.

Signed-off-by: slonka <slonka@users.noreply.github.com>
Co-authored-by: Charly Molter <charly@molter.io>
Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka merged commit 9768528 into kumahq:master Jan 19, 2023
@colinh-kong
Copy link

NICE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants