Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-cp) use new dp format across the project #580

Merged
merged 3 commits into from
Feb 18, 2020
Merged

chore(kuma-cp) use new dp format across the project #580

merged 3 commits into from
Feb 18, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Changed the DP format across the project for two reasons

  1. Check if the new format is compatible everywhere
  2. Removing old format will be easier in the future.

@jakubdyszkiewicz jakubdyszkiewicz requested review from a team and yskopets February 13, 2020 17:24
yskopets
yskopets approved these changes Feb 14, 2020
View reviewed changes
api/mesh/v1alpha1/dataplane_test.go Show resolved Hide resolved
app/kumactl/cmd/inspect/inspect_dataplanes_test.go Outdated Show resolved Hide resolved
app/kumactl/cmd/inspect/inspect_dataplanes_test.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz jakubdyszkiewicz changed the base branch from feature/gateway-metrics to master February 18, 2020 12:28
@jakubdyszkiewicz jakubdyszkiewicz merged commit 2de0b4e into master Feb 18, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/dp-new-format-project branch February 28, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskopets yskopets yskopets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @yskopets