Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp) TrafficTrace entity #582

Merged
merged 6 commits into from
Feb 18, 2020
Merged

feat(kuma-cp) TrafficTrace entity #582

merged 6 commits into from
Feb 18, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Added Traffic Trace entity for selecting dataplanes for which we will enable tracing.

@jakubdyszkiewicz jakubdyszkiewicz requested review from a team and yskopets February 14, 2020 14:41
yskopets
yskopets suggested changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please also include into this PR k8s RBAC config for TrafficRoute resource ?

api/mesh/v1alpha1/traffic_trace.proto Outdated Show resolved Hide resolved
pkg/core/resources/apis/mesh/traffic_trace_validator_test.go Show resolved Hide resolved
pkg/core/resources/apis/mesh/validators.go Outdated Show resolved Hide resolved
@yskopets
Copy link
Contributor

Could we please also update k8s ValidatingWebhookConfiguration to include traffictraces as part of this PR ?

@yskopets
Copy link
Contributor

Could we please also add TrafficTrace-related test cases to pkg/plugins/resources/k8s/native/api/v1alpha1/global_type_registry_test.go as part of this PR ?

@jakubdyszkiewicz jakubdyszkiewicz merged commit 7084a8a into master Feb 18, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/traffic-trace-entity branch February 28, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskopets yskopets yskopets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @yskopets