feat(kuma-cp): init container first by default #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekth
force-pushed
the
fix/init-container-order
branch
from
8213686
to
1848a4d
Compare
|
/golden_files |
As K8s by default doesn't guarantee anything about startup and order of containers I don't think it's useful to add an annotation to control this. I think the only place we'd add an annotation is for the 2nd part of this work (the one that adds a preStart hook) |
zekth
requested review from
a team,
lobkovilya and
lukidzi
and removed request for
a team
zekth
force-pushed
the
fix/init-container-order
branch
from
f35d8e5
to
142d4de
Compare
michaelbeaumont
changed the title
lahabana
changed the title
|
@lobkovilya or @lukidzi can we get a review/merge on this? |
lukidzi
approved these changes
Feb 16, 2023
Signed-off-by: Vincent Le Goff <vincent.legoff@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zekth
force-pushed
the
fix/init-container-order
branch
from
9c1d060
to
053f462
Compare
slonka
added a commit
to slonka/kuma
that referenced
this pull request
Apr 14, 2023
This reverts commit 6cf9648.
6 tasks
slonka
added a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #3121 to put the init container as first by default. I might be missing something; happy to work on this if there is other things needed.
Question is do we want to make this operation as an option? So do we create a pod annotation for this?
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?