chore(kuma-cp) generify proxy template matching #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/proxy-template-generify-matcher
branch
from
eb307ad
to
2733c5b
Compare
yskopets
suggested changes
Feb 19, 2020
|
Refactored to support * and gateways. Please take a look. |
yskopets
approved these changes
Feb 20, 2020
| // when | ||
| actual := policy.SelectDataplanePolicy(given.proxy.Dataplane, given.policies) | ||
| // then | ||
| if given.expected == nil { |
There was a problem hiding this comment.
Wouldn't Expect(actual).To(Equal(given.expected)) be enough for both cases ?
There was a problem hiding this comment.
Apparently it is not
Refusing to compare <nil> to <nil>.
Be explicit and use BeNil() instead. This is to avoid mistakes where both sides of an assertion are erroneously uninitialized.
| Spec: mesh_proto.Dataplane{ | ||
| Networking: &mesh_proto.Dataplane_Networking{ | ||
| Inbound: []*mesh_proto.Dataplane_Networking_Inbound{ | ||
| {}, |
There was a problem hiding this comment.
Why do we want to test against invalid inbound listeners ?
There was a problem hiding this comment.
It was in the previous test, but I agree - it doesn't make sense, deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce DataplanePolicy and generify matching for ProxyTemplate. This enables us to reuse the same logic for TrafficTrace as well as soon to be refactored TrafficLog