feat(kuma-cp) Generate tracing on listeners #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
reviewed
Feb 19, 2020
jakubdyszkiewicz
force-pushed
the
feature/generate-tracing-on-listeners
branch
from
ed8d010
to
cd4c738
Compare
It's possible now. |
yskopets
reviewed
Feb 20, 2020
There was a problem hiding this comment.
Let's clarify with @subnetmarco how Kuma should behave in case of 0.0 % sampling set by a user
jakubdyszkiewicz
force-pushed
the
feature/generate-tracing-on-listeners
branch
from
cd4c738
to
ae11c40
Compare
jakubdyszkiewicz
changed the base branch from
feature/proxy-template-generify-matcher
to
master
jakubdyszkiewicz
force-pushed
the
feature/generate-tracing-on-listeners
branch
from
ae11c40
to
910a126
Compare
yskopets
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generate tracing config on http configuration manager.
Still missing configuration of tracing itself in bootstrap config.