kuma-cp: add support for %KUMA_*% placeholders inside Envoy access log format #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
feature/add-kuma-variables-to-envoy-access-log-format
branch
from
f824b37
to
77bd4d9
Compare
yskopets
force-pushed
the
feature/support-full-envoy-access-log-format
branch
from
8e754f1
to
8d402ee
Compare
yskopets
force-pushed
the
feature/add-kuma-variables-to-envoy-access-log-format
branch
9 times, most recently
from
1fedea4
to
dba94fa
Compare
jakubdyszkiewicz
approved these changes
Feb 24, 2020
pkg/envoy/accesslog/interfaces.go
Outdated
| @@ -41,3 +41,27 @@ type HttpLogConfigurer interface { | |||
| type TcpLogConfigurer interface { | |||
| ConfigureTcpLog(config *accesslog_config.TcpGrpcAccessLogConfig) error | |||
| } | |||
|
|
|||
| // InterpolationContext represents a context of Interpolate() operation. | |||
| type InterpolationContext interface { | |||
There was a problem hiding this comment.
Do we need this interface? How about just using InterpolationVariables?
yskopets
force-pushed
the
feature/add-kuma-variables-to-envoy-access-log-format
branch
from
dba94fa
to
d710f15
Compare
yskopets
force-pushed
the
feature/support-full-envoy-access-log-format
branch
from
6f281f6
to
196639f
Compare
yskopets
force-pushed
the
feature/add-kuma-variables-to-envoy-access-log-format
branch
from
d710f15
to
32d0335
Compare
yskopets
force-pushed
the
feature/add-kuma-variables-to-envoy-access-log-format
branch
from
32d0335
to
21ffa71
Compare
yskopets
changed the base branch from
feature/support-full-envoy-access-log-format
to
master
devadvocado
deleted the
feature/add-kuma-variables-to-envoy-access-log-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
%KUMA_*%placeholders inside Envoy access log format