Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MeshHTTPRoute): add header matching #5943

Merged
merged 9 commits into from
Feb 8, 2023
Merged

feat(MeshHTTPRoute): add header matching #5943

merged 9 commits into from
Feb 8, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Feb 7, 2023 •
edited
Loading

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- Closes MeshHTTPRoute header matching #5794
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- none
  • Manual Universal Tests --
  • Manual Kubernetes Tests -- none
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont
feat(MeshHTTPRoute): add header match to API
21b24d4 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: regenerate
99c2104 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
build(generate): all files in api/common
2554636 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat(MeshHTTPRoute): add header matching
80b07c9 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshHTTPRoute): header matching
d181607 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat(MeshHTTPRoute): validate header matching
2b3f1d7 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: kumactl golden files
967bc8e 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review February 7, 2023 17:36
@michaelbeaumont michaelbeaumont requested review from a team, jakubdyszkiewicz and Automaat and removed request for a team February 7, 2023 17:36
lobkovilya
lobkovilya reviewed Feb 8, 2023
View reviewed changes
api/common/v1alpha1/header.go Outdated Show resolved Hide resolved
mk/generate.mk Show resolved Hide resolved
api/common/v1alpha1/header.go Outdated Show resolved Hide resolved
@michaelbeaumont
feat: don't require a header value field be set
abe938a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) February 8, 2023 16:04
@michaelbeaumont
chore: generate
b3a72e8 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 321bece into kumahq:master Feb 8, 2023
@michaelbeaumont michaelbeaumont deleted the feat/route_header_match branch February 8, 2023 17:39
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya left review comments

@Automaat Automaat Automaat approved these changes

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshHTTPRoute header matching
3 participants
@michaelbeaumont @Automaat @lobkovilya