Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuma-cp: include k8s namespace into a set of labels that describe a given Dataplane to Prometheus #601

Merged
merged 3 commits into from
Feb 28, 2020
Merged

kuma-cp: include k8s namespace into a set of labels that describe a given Dataplane to Prometheus #601

merged 3 commits into from
Feb 28, 2020

Conversation

yskopets
Copy link
Contributor

Summary

  • include k8s namespace into a set of labels that describe a given Dataplane to Prometheus

@yskopets yskopets requested review from a team and jakubdyszkiewicz February 25, 2020 13:26
@yskopets yskopets added this to the 0.4.0 milestone Feb 25, 2020
@yskopets yskopets force-pushed the feature/expose-k8s-namespace-label-to-prometheus branch from 420ca14 to e501006 Compare February 25, 2020 14:21
jakubdyszkiewicz
jakubdyszkiewicz reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we gonna use this in our Grafana Dashboards?
Will there be an extra "namespace" picker next to "mesh" and "name" in Kuma Dataplane? If so will this work on universal? Are we gonna maintain two separate dashboards for universal and k8s?

@yskopets
Copy link
Contributor Author

yskopets commented Feb 27, 2020 •
edited

@subnetmarco In the current implementation (this PR) k8s namespace label is only exported on k8s and has a very distinctive name - k8s_kuma_io_namespace.

@jakubdyszkiewicz makes an argument that it creates a need to maintain separate dashboards for k8s and universal.

What should we do ?

@subnetmarco
Copy link
Contributor

@jakubdyszkiewicz why adding an extra info (in this case k8s_kuma_io_namespace) forces us to having to maintain two dashboards, one for Kubernetes and one for Universal?

@yskopets yskopets force-pushed the feature/expose-k8s-namespace-label-to-prometheus branch from e501006 to 15db333 Compare February 28, 2020 12:08
@yskopets yskopets merged commit e269351 into master Feb 28, 2020
@devadvocado devadvocado deleted the feature/expose-k8s-namespace-label-to-prometheus branch March 30, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yskopets @subnetmarco @jakubdyszkiewicz