kuma-cp: add a validating admission web hook to verify correctness of <port>.service.kuma.io/protocol annotations on k8s Service objects
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can we / Does it make sense to also validate that for example with "8080.service.kuma.io/protocol" there is actually port 8080 in the service? While testing tracing I made a mistake that I put a wrong port (8080 instead of 3001) and it took me a while to figure out my mistake.
yskopets
force-pushed
the
feature/improve-ux-on-k8s-by-returning-descriptive-error-messages
branch
from
45c4410
to
6074951
Compare
jakubdyszkiewicz
force-pushed
the
feature/add-validating-web-hook-for-k8s-services
branch
from
047e362
to
2b90a8c
Compare
jakubdyszkiewicz
changed the base branch from
feature/improve-ux-on-k8s-by-returning-descriptive-error-messages
to
master
jakubdyszkiewicz
force-pushed
the
feature/add-validating-web-hook-for-k8s-services
branch
from
2b90a8c
to
af9bc51
Compare
jakubdyszkiewicz
deleted the
feature/add-validating-web-hook-for-k8s-services
branch
tharun208
pushed a commit
to tharun208/kuma
that referenced
this pull request
Apr 6, 2020
…ss of `<port>.service.kuma.io/protocol` annotations on k8s Service objects (kumahq#611)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<port>.service.kuma.io/protocolannotations onk8sServiceobjects