control-plane: track status of Dataplanes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
feature/track-dataplane-status
branch
from
60b030a
to
9d843c0
Compare
jakubdyszkiewicz
requested changes
Jul 15, 2019
components/konvoy-control-plane/pkg/xds/server/dataplane_status_sink.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/dataplane_status_sink.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/dataplane_status_sink.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/dataplane_status_tracker.go
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/dataplane_status_tracker.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/dataplane_status_sink.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/dataplane_status_tracker.go
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/dataplane_status_sink.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/xds/server/dataplane_status_tracker.go
Show resolved
Hide resolved
Yes, I will not merge it without unit tests. |
yskopets
force-pushed
the
feature/track-dataplane-status
branch
from
c300f95
to
453c778
Compare
yskopets
force-pushed
the
feature/add-dataplane-resource
branch
2 times, most recently
from
3b9b080
to
bb9b6cb
Compare
yskopets
force-pushed
the
feature/track-dataplane-status
branch
from
453c778
to
70177f8
Compare
yskopets
force-pushed
the
feature/add-dataplane-resource
branch
from
bb9b6cb
to
264f281
Compare
yskopets
force-pushed
the
feature/track-dataplane-status
branch
from
70177f8
to
2ec2cba
Compare
|
Added unit tests |
yskopets
force-pushed
the
feature/track-dataplane-status
branch
from
11a3316
to
c98e090
Compare
jakubdyszkiewicz
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
DataplanestatusDataplanestatus periodically (1 per second)make start/depsandmake run/example/envoycommands to easily bootstrap environment for local development