Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the mesh to the access logs - http and network #620

Merged
merged 1 commit into from
Mar 11, 2020
Merged

added the mesh to the access logs - http and network #620

merged 1 commit into from
Mar 11, 2020

Conversation

pradeepmurugesan
Copy link
Contributor

@pradeepmurugesan pradeepmurugesan commented Mar 6, 2020 •
edited

Summary

Included the Mesh name in the access log.

Full changelog

Modified the format of

  1. defaultHttpAccessLogFormat
  2. defaultNetworkAccessLogFormat

Issues resolved

Fix #599

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@pradeepmurugesan pradeepmurugesan marked this pull request as ready for review March 7, 2020 18:15
@pradeepmurugesan pradeepmurugesan requested a review from a team March 7, 2020 18:15
@pradeepmurugesan pradeepmurugesan changed the title [WIP] added the mesh to the access logs - http and network added the mesh to the access logs - http and network Mar 7, 2020
@subnetmarco
Copy link
Contributor

Thanks for the contribution! We will review it soon.

jakubdyszkiewicz
jakubdyszkiewicz approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jakubdyszkiewicz jakubdyszkiewicz merged commit fae4003 into kumahq:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce a %KUMA_MESH% command operator into access log format
4 participants
@pradeepmurugesan @CLAassistant @subnetmarco @jakubdyszkiewicz