Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: add replace for fsnotify dependency #623

Merged
merged 1 commit into from
Mar 11, 2020
Merged

go.mod: add replace for fsnotify dependency #623

merged 1 commit into from
Mar 11, 2020

Conversation

lobkovilya
Copy link
Contributor

Summary

make dev/install/ginkgo fails with

go: gopkg.in/fsnotify.v1@v1.4.8: go.mod has non-....v1 module path "github.com/fsnotify/fsnotify" at revision v1.4.8

As a workaround added replace to go.mod file

Related issue: onsi/ginkgo#650

@lobkovilya lobkovilya requested a review from a team March 11, 2020 06:24
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
but let's watch the original issue, so we can remove the workaround once ginkgo guys will fix it.

@lobkovilya lobkovilya merged commit bb69f61 into kumahq:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lobkovilya @jakubdyszkiewicz