Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): add annotation to have custom address #6289

Merged
merged 4 commits into from
Mar 30, 2023
Merged

feat(metrics): add annotation to have custom address #6289

merged 4 commits into from
Mar 30, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Mar 16, 2023 •
edited
Loading

Checklist prior to review

Changelog: feat(k8s): add annotation prometheus.metrics.kuma.io/aggregate-application-address to scrape custom address on k8s

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

slonka and others added 2 commits March 16, 2023 15:27
@slonka
feat(metrics): add annotation to have custom address
b181c33 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@lukidzi
feat(kuma-cp): do not use probe when binding to localhost
cd7c957 
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@slonka slonka marked this pull request as ready for review March 29, 2023 14:38
@slonka slonka requested review from a team, bartsmykla and lobkovilya and removed request for a team March 29, 2023 14:38
@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Mar 29, 2023
@slonka slonka changed the title feat(metrics): add annotation to have custom address [WIP] feat(metrics): add annotation to have custom address Mar 29, 2023
@slonka slonka merged commit bbf868b into kumahq:master Mar 30, 2023
@slonka slonka deleted the add-k8s-annotation-for-aggregation-address branch March 30, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slonka @bartsmykla @lukidzi @lahabana