control-plane: api on mesh itself #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Consumes(restful.MIME_JSON). | ||
| Produces(restful.MIME_JSON) | ||
|
|
||
| addToWs(ws, definitions, resourceStore, config) |
There was a problem hiding this comment.
It turned out that if you add multiple ws with /meshes prefix. It cannot work, because
/meshes/{:name}
and
/meshes/{:name}/traffic-routes/{:name}
are converted for the same path /meshes under the hood in http.HandleFunc. That's why we have to add every resource with this prefix (which is essentially every resource) within one ws
yskopets
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
GET /meshes
GET /meshes/:name
PUT /meshes/:name
DELETE /meshes/:name
The test is basically a copy paste of the traffic resource test as I could not find proper abstraction for it.