feat(kuma-cp) log external services #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For TrafficLog, we configure Dataplanes that match sources to log requests for a matching destination. We also want to log now the requests for external services. Such requests with transparent proxying (only on K8S for now) goes through
pass_throughL4 cluster andcatch_alllistener, therefore we want to configure such listener with access logs.This will only be placed when in the destination section we will have the
*.In the future, this will be improved with more sophisticated handling of external services that will let apply L7 policies/metrics/logging etc.