Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(injector) explicitly set parameters in securityContext #631

Merged
merged 2 commits into from
Mar 16, 2020
Merged

fix(injector) explicitly set parameters in securityContext #631

merged 2 commits into from
Mar 16, 2020

Conversation

lobkovilya
Copy link
Contributor

Summary

kuma-init didn't set runAsUser and runAsGroup explicitly, that's why pod-level securityContext could override them.

Full changelog

  • Explicitly set runAsUser and runAsGroup to 0.

Issues resolved

Fix https://github.com/Kong/kuma/issues/571

@lobkovilya lobkovilya requested a review from a team March 13, 2020 19:42
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog

@lobkovilya lobkovilya force-pushed the fix/kuma-init-security-context branch from d8a8661 to 290bd27 Compare March 16, 2020 13:36
@lobkovilya lobkovilya merged commit 7cdcbb4 into master Mar 16, 2020
@devadvocado devadvocado deleted the fix/kuma-init-security-context branch March 30, 2020 13:16
@ghost ghost mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lobkovilya @jakubdyszkiewicz