chore(kuma-dp) refactor to components #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobkovilya
approved these changes
Mar 24, 2020
| go func() { | ||
| defer close(logServerErr) | ||
| if err := server.Start(cfg.Dataplane); err != nil { | ||
| runLog.Error(err, "problem running Access Log server") |
There was a problem hiding this comment.
Why did you eliminate that log line, it looks useful for troubleshooting process
There was a problem hiding this comment.
It's now handled by: runLog.Error(err, "error while running Kuma DP")
If any component returns an error the componentMgr.Start returns an error.
There was a problem hiding this comment.
Yes, but it will return err := s.server.Serve(lis) which is actually a grpc error. So we won't understand which exactly component failed to start.
| go func() { | ||
| defer close(dataplaneErr) | ||
| if err := dataplane.Run(core.SetupSignalHandler()); err != nil { | ||
| runLog.Error(err, "problem running Dataplane (Envoy)") |
There was a problem hiding this comment.
It's now handled by: runLog.Error(err, "error while running Kuma DP")
If any component returns an error the componentMgr.Start returns an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a concept in Kuma CP called
Components. Component can be a grpcServer, httpServer, some background process etc. (This concept is borrowed from K8S codebase). When CP starts, it register several components into Manager and Manager starts all the components.Since soon we will be introducing another server into Kuma DP, I think we should reuse Component concept in Kuma DP.
I made slight modification to our Component/Manager interfaces to get rid of K8S imports, therefore the need of this small
kubeComponentManagerstruct. Otherwise we would be embedding K8S code into Kuma DP. DP should be as lightweight as possible.