feat(kuma-cp) Fault Injection entity #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,7 @@ var _ = Describe("kumactl install control-plane", func() { | |||
| // then | |||
| Expect(actual).To(MatchYAML(expected)) | |||
| // and | |||
| actualManifests := data.SplitYAML(data.File{Data: expected}) | |||
| actualManifests := data.SplitYAML(data.File{Data: actual}) | |||
There was a problem hiding this comment.
Good catch! I was having problems with this last time I edited the install script and was wondering what is going on.
|
don't forget about Kuma GUI but this comes with a separate PR. You can ask @bloqhead for help if needed. |
|
Please remember to also write documentation for this on https://github.com/Kong/kuma-website, and update the |
jakubdyszkiewicz
requested changes
Mar 26, 2020
jakubdyszkiewicz
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
FaultInjectionentityFull changelog
*.protokumactl