Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*) prevent dataplane creation with a headless services and provide more descriptive error message on pod converter error #651

Merged
merged 2 commits into from
Apr 2, 2020
Merged

chore(*) prevent dataplane creation with a headless services and provide more descriptive error message on pod converter error #651

merged 2 commits into from
Apr 2, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

This change covers a couple of things:

  • Provide more descriptive error message in Kuma DP on K8S when Pod was not converted to Dataplane in K8S
  • Prevent creating a Dataplane with Headless Service. Otherwise other dataplanes will create outbound listeners to it and they will fail with doing so, because outbound address is not valid.
  • Provide a message suggesting what can be done with such situation (either change the service or exclude Pod from the mesh)

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team March 31, 2020 15:08
subnetmarco
subnetmarco suggested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@subnetmarco subnetmarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments when it comes to the error messages.

app/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go Outdated Show resolved Hide resolved
pkg/plugins/discovery/k8s/controllers/pod_converter.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz jakubdyszkiewicz merged commit 2bac6f0 into master Apr 2, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/better-error-msg branch April 2, 2020 18:25
@nickolaev
Copy link
Contributor

This one treats some part of #561.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subnetmarco subnetmarco subnetmarco approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubdyszkiewicz @nickolaev @subnetmarco