Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): wait between the proxy termination and its deregistration #6533

Merged

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Apr 14, 2023

As a result, there was no sleep between the proxy termination and its deregistration.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: ilya.lobkov@konghq.com <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested review from a team, michaelbeaumont and bartsmykla and removed request for a team April 14, 2023 06:42
@lahabana
Copy link
Contributor

@lobkovilya I think the title of the PR should be what it fixes. .i.e: "wait between the proxy termination and its deregistration"
This is because this is what lands on the changelog users care about behaviour not actual change. (You can expand on the change in the commit content)

@lobkovilya lobkovilya changed the title fix(kuma-cp): add missing '<-' for time.After fix(kuma-cp): wait between the proxy termination and its deregistration Apr 14, 2023
@lobkovilya lobkovilya merged commit 11a38a7 into kumahq:master Apr 18, 2023
4 checks passed
@lobkovilya lobkovilya deleted the fix/time-after-when-deregister-proxy branch April 18, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants