feat(cli): kumactl install tracing #655
Conversation
| return strings.HasSuffix(file.Name, ".yaml") | ||
| }) | ||
|
|
||
| renderedFiles, err := renderFiles(yamlTemplateFiles, templateArgs, simpleTemplateRenderer) |
There was a problem hiding this comment.
You should be able to just pass templateFiles instead of yamlTemplateFiles because all files for tracing are YAML files
There was a problem hiding this comment.
I used the existing code in install_metrics.go that also uses yamlTemplateFiles. Should it change in both?
There was a problem hiding this comment.
It's needed for metrics because we also have .json files, so we have to filter those.
| - env: | ||
| - name: COLLECTOR_ZIPKIN_HTTP_PORT | ||
| value: "9411" | ||
| image: jaegertracing/all-in-one |
There was a problem hiding this comment.
Is it a good idea to leave here the latest version? What if Jaeger releases a new version and this YAML is not compatible with it? I think it's more reliable to lock the version here. Of course this comes at the cost of updating the version every now and then, but then we are sure that we are providing the command that works.
We locked the version in metrics Prometheus + Grafana deployment.
| @@ -0,0 +1,163 @@ | |||
| # | |||
There was a problem hiding this comment.
Can you maybe also add a comment with a link on which this file is based?
Adding
kumactl install tracingto automatically provision Jaeger with Zipkin compatibility in akuma-tracingnamespace.Goes in hand with kumahq/kuma-website#167